fix: make kernel URL substitution work for major.minor releases #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilaolah
force-pushed
the
kernel-url
branch
from
1d1c594
to
63f72a0
Compare
attilaolah
commented
Nov 19, 2024
| @@ -5,7 +5,7 @@ dependencies: | |||
| - image: '{{ .TOOLS_IMAGE }}' | |||
| steps: | |||
| - sources: | |||
| - url: https://cdn.kernel.org/pub/linux/kernel/v{{ regexReplaceAll ".\\d+\\.\\d+$" .linux_version "${1}" }}.x/linux-{{ .linux_version }}.tar.xz | |||
| - url: https://cdn.kernel.org/pub/linux/kernel/v{{ regexReplaceAll ".\\d+(\\.\\d+)?$" .linux_version "${1}" }}.x/linux-{{ .linux_version }}.tar.xz | |||
There was a problem hiding this comment.
Or we could simplify the regex to (\.\d+)+, that would leave only the major version, should also work, right?
For kernels without a patch version (e.g. 6.12), the directory seems to be 6.x itnheai of 6.12.x.
attilaolah
force-pushed
the
kernel-url
branch
from
63f72a0
to
8b1dc36
Compare
attilaolah
changed the title
|
Oh I guess this can be closed in favour of #1085, which changes the URL to GitHub… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For kernels without a patch version (e.g. 6.12), the directory seems to be 6.x itnheai of 6.12.x.