Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brotli-size to 4.0.0 and get rid of iltorb #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gugadev
Copy link

@gugadev gugadev commented Mar 30, 2021

Description

Update brotli-size to 4.0.0 and get rid of iltorb 2.4.5 (getting 404 errors because some releases are removed from repo).

Types of changes

  • New feature: update brotli-size dependency

@romain-guillot-symphony

Hi maintainers! Is there any blockers to merge this PR?

@siddharthkp
Copy link
Owner

Hi!

Checkout #320 (comment)

@BobForCat
Copy link

Hi,

I can't believe I have the same problem (about iltorb hard installation) and that you have an open PR on that !! But I can't use the bundlesize2 as I try to install antd package https://github.com/ant-design/ant-design/blob/master/package.json#L186 so I can only wait for your PR

So I'm asking the same : Is there any blockers to merge this PR? Do you have any schedule for it ? I'm only waiting for it 😄

Thanks !

@gracjan-sl
Copy link

I also have issues with iltorb. @siddharthkp would it be possible to merge this and get rid of the dependency?

@siddharthkp
Copy link
Owner

Hi @gracjan-sl!

You might want to start using bundlesize2 that solves this issue: https://github.com/siddharthkp/bundlesize2#migration-from-bundlesize0180

@kebugcheckex
Copy link

Is there any blockers for this PR to be merged?

I saw a sentence on bundlesize2's GitHub page

Note: When this package is feature complete, it will be merged back into the original project as [email protected]

Does that mean until bundlesize2 is merged back to this repo, the existing code will not be updated?

@siddharthkp
Copy link
Owner

Does that mean until bundlesize2 is merged back to this repo, the existing code will not be updated?

Pretty much, I'd recommend using bundlesize2, it solves for most of the use cases right now (not all).

I understand it's not good open source behavior but it's the best I've got right now 😅

@breadadams
Copy link

@siddharthkp what's the reason this PR can't be merged?

We moved over to bundlesize2 (because of a vulnerability in iltorb) however the last release over there was 3 years ago and it doesn't look to be maintained (?). For example no response on siddharthkp/bundlesize2#41 where I've asked to contribute so we can opt-out of caching.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants