Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier reporter #321

Merged
merged 9 commits into from
Jul 9, 2019
Merged

Prettier reporter #321

merged 9 commits into from
Jul 9, 2019

Conversation

siddharthkp
Copy link
Owner

@siddharthkp siddharthkp commented Jul 4, 2019

Rewrote the reporter to make the results easily readable (and pretty - heavily inspired by ava)

Before:

Screenshot 2019-07-04 at 8 54 24 PM

After:

Screenshot 2019-07-04 at 8 56 30 PM

TODO:

  • Normalize config before it reaches reporter
  • Add information about master
  • Refactor build message?

@palashmon
Copy link
Collaborator

IMG

One thing I noticed in this image. At last, it says that "1 checks failed" but I think that should be just "check" when failed or pass count is 1.

Also, we might need to test the reporter/cli for cases where we have long files names as mentioned in a PR #293 We just need to check the file names are not overlapping with size result (270B < 300B) in the last column.

Otherwise, the new reporter is looking great 👍

@siddharthkp
Copy link
Owner Author

One thing I noticed in this image. At last, it says that "1 checks failed" but I think that should be just "check" when failed or pass count is 1.

Fixed!

Also, we might need to test the reporter/cli for cases where we have long files names

already taken care of 😄

@palashmon
Copy link
Collaborator

Awesome 😃

@siddharthkp siddharthkp changed the base branch from master to beta July 9, 2019 10:18
@siddharthkp siddharthkp merged commit da81cb0 into beta Jul 9, 2019
@siddharthkp siddharthkp deleted the prettier-reporter branch July 9, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants