Exit script with error even if token is provided #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
bundlesize
fails a check, exit with status code of1
.Motivation and Context
In certain CIs, the exit status is used to indicate whether the build succeeded or failed. Currently, if a CI token is provided, the build exits with
0
status code always (even if the check failed) hence some CIs will always markbundlesize
builds as successful.Types of changes
Previously passing builds in CIs will now fail if
bundlesize
check fails.Checklist: