Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit script with error even if token is provided #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weynsee
Copy link

@weynsee weynsee commented Jul 12, 2018

Description

When bundlesize fails a check, exit with status code of 1.

Motivation and Context

In certain CIs, the exit status is used to indicate whether the build succeeded or failed. Currently, if a CI token is provided, the build exits with 0 status code always (even if the check failed) hence some CIs will always mark bundlesize builds as successful.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
    Previously passing builds in CIs will now fail if bundlesize check fails.

Checklist:

  • My code follows the code style of this project. ✅
  • If my change requires a change to the documentation I have updated the documentation accordingly. ✅
  • I have read the CONTRIBUTING document. ✅
  • I created an issue for the Pull Request ✅

@oliverviljamaa
Copy link

@siddharthkp Have you considered this PR?

@kefranabg
Copy link

Some news on this PR ? bundlesize cannot be used on CI process without this feature 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants