Simplify RPM support to Python 3 only #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the VNCDoTool no longer officially supports Python 2 we can simplify the RPM spec file and restore compatibility with most recent RPM packager distros. Signed-off-by: Plamen Dimitrov <[email protected]>
pevogam
force-pushed
the
rpm-python3-update
branch
from
e7971df
to
6f6d2c4
Compare
|
Hi @sibson, have you considered a later update of the python packaging via a toml file as described in the latest packaging guidelines from https://packaging.python.org/en/latest/tutorials/packaging-projects/#creating-pyproject-toml? I am just wondering. Otherwise I will be glad if you consider this pull request restricts RPM packaging to python 3 only, updates, and simplifies it. |
|
thanks, ✨ 🍰 ✨ I've not thought about toml. Assuming there are no regressions I wouldn't object to upgrading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the VNCDoTool no longer officially supports Python 2 we can simplify the RPM spec file and restore compatibility with most recent RPM packager distros.