chore: simplify selection params

sibiraj-s · Nov 29, 2020 · 5bf6731 · 5bf6731
1 parent 38c47f5
commit 5bf6731
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/plugins/menu/items/link.ts b/src/plugins/menu/items/link.ts
@@ -62,7 +62,8 @@ const link = (view: EditorView, spec: MenuItemSpec): MenuItemViewRender => {
 
   const onPopupOpen = () => {
     const { state } = view;
-    const { doc, selection: { from, to, empty }, schema } = state;
+    const { doc, selection, schema } = state;
+    const { from, to, empty } = selection;
     const isActive = isMarkActive(state, schema.marks.link);
 
     if (isActive) {
@@ -72,9 +73,11 @@ const link = (view: EditorView, spec: MenuItemSpec): MenuItemViewRender => {
 
     const selectedText = !empty ? doc.textBetween(from, to) : '';
 
-    const nodeSelection = state.selection as NodeSelection;
-    const isImageNode = nodeSelection.node?.type.name === 'image';
-    const isTextDisabled = isImageNode ?? false;
+    let isTextDisabled = false;
+
+    if (selection instanceof NodeSelection) {
+      isTextDisabled = selection.node.type.name === 'image';
+    }
 
     renderForm(getFormInputs(selectedText, isTextDisabled));
     return true;