chore: unsubscribe subscription onDestroy

sibiraj-s · Dec 5, 2017 · 38245cb · 38245cb
1 parent 3ad981a
commit 38245cb
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -56,6 +56,7 @@ Then in HTML
 For `ngModel` to work, You must import `FromsModule` from `@angular/forms`
 
 ### Documentation
+
 Check [wiki][wiki] for more information 
 
 [npm]: https://www.npmjs.com/

diff --git a/docs/3rdpartylicenses.txt b/docs/3rdpartylicenses.txt
@@ -67,6 +67,6 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 
-@angular/[email protected].0
+@angular/[email protected].3
 MIT
 MIT
diff --git a/docs/index.html b/docs/index.html
@@ -1 +1 @@
-<!doctype html><html lang="en"><head><meta charset="utf-8"><title>NgxEditor</title><base href="ngx-editor"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="icon" type="image/x-icon" href="favicon.ico"><link href="styles.3ccbe96a5a764c24870d.bundle.css" rel="stylesheet"/></head><body><app-root></app-root><script async defer="defer" src="https://buttons.github.io/buttons.js"></script><script type="text/javascript" src="inline.90775b056b82a9127190.bundle.js"></script><script type="text/javascript" src="polyfills.ad37cd45a71cb38eee76.bundle.js"></script><script type="text/javascript" src="main.4dfced48e5839ada9fe7.bundle.js"></script></body></html>
+<!doctype html><html lang="en"><head><meta charset="utf-8"><title>NgxEditor</title><base href="ngx-editor"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="icon" type="image/x-icon" href="favicon.ico"><link href="styles.3ccbe96a5a764c24870d.bundle.css" rel="stylesheet"/></head><body><app-root></app-root><script async defer="defer" src="https://buttons.github.io/buttons.js"></script><script type="text/javascript" src="inline.dd8a541cfbc7a0565666.bundle.js"></script><script type="text/javascript" src="polyfills.ad37cd45a71cb38eee76.bundle.js"></script><script type="text/javascript" src="main.f4002c6365bd7516a919.bundle.js"></script></body></html>
diff --git a/docs/inline.90775b056b82a9127190.bundle.js → docs/inline.dd8a541cfbc7a0565666.bundle.js b/docs/inline.90775b056b82a9127190.bundle.js → docs/inline.dd8a541cfbc7a0565666.bundle.js
diff --git a/docs/main.4dfced48e5839ada9fe7.bundle.js b/docs/main.4dfced48e5839ada9fe7.bundle.js
diff --git a/docs/main.f4002c6365bd7516a919.bundle.js b/docs/main.f4002c6365bd7516a919.bundle.js
diff --git a/docs/polyfills.ad37cd45a71cb38eee76.bundle.js b/docs/polyfills.ad37cd45a71cb38eee76.bundle.js
diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -1,5 +1,6 @@
-import { Component, OnInit } from '@angular/core';
+import { Component, OnInit, OnDestroy } from '@angular/core';
 import { AppService } from './app.service';
+import { Subject } from 'rxjs/Subject';
 
 @Component({
   selector: 'app-root',
@@ -8,9 +9,11 @@ import { AppService } from './app.service';
   providers: [AppService]
 })
 
-export class AppComponent implements OnInit {
+export class AppComponent implements OnInit, OnDestroy {
+
   title = 'ngx-editor';
   latestRelease: any = {};
+  private subscription: Subject<any> = new Subject();
 
   editorConfig = {
     editable: true,
@@ -26,16 +29,20 @@ export class AppComponent implements OnInit {
   constructor(private _appService: AppService) { }
 
   getLatestRelease() {
-    this._appService.getLatestRelease().subscribe(
+    this.subscription = this._appService.getLatestRelease().subscribe(
       data => this.latestRelease = data,
       error => { console.log(error); },
       () => {
-        // console.log('latest release: ' + this.latestRelease['name']);
+        console.log('latest release: ' + this.latestRelease['name']);
       });
   }
 
   ngOnInit() {
     this.getLatestRelease();
   }
 
+  ngOnDestroy() {
+    this.subscription.unsubscribe();
+  }
+
 }
diff --git a/src/app/app.service.ts b/src/app/app.service.ts
@@ -9,10 +9,10 @@ export class AppService {
 
   constructor(private _http: HttpClient) { }
 
-  getLatestRelease() {
+  getLatestRelease(): any {
 
     return this._http.get(this.releaseURL)
-      .map((response) => {
+      .map((response: any) => {
         if (response && response['length'] !== 0) {
           return response;
         } else {
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<!doctype html><html lang="en"><head><meta charset="utf-8"><title>NgxEditor</title><base href="ngx-editor"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="icon" type="image/x-icon" href="favicon.ico"><link href="styles.3ccbe96a5a764c24870d.bundle.css" rel="stylesheet"/></head><body><app-root></app-root><script async defer="defer" src="https://buttons.github.io/buttons.js"></script><script type="text/javascript" src="inline.90775b056b82a9127190.bundle.js"></script><script type="text/javascript" src="polyfills.ad37cd45a71cb38eee76.bundle.js"></script><script type="text/javascript" src="main.4dfced48e5839ada9fe7.bundle.js"></script></body></html>
		<!doctype html><html lang="en"><head><meta charset="utf-8"><title>NgxEditor</title><base href="ngx-editor"><meta name="viewport" content="width=device-width,initial-scale=1"><link rel="icon" type="image/x-icon" href="favicon.ico"><link href="styles.3ccbe96a5a764c24870d.bundle.css" rel="stylesheet"/></head><body><app-root></app-root><script async defer="defer" src="https://buttons.github.io/buttons.js"></script><script type="text/javascript" src="inline.dd8a541cfbc7a0565666.bundle.js"></script><script type="text/javascript" src="polyfills.ad37cd45a71cb38eee76.bundle.js"></script><script type="text/javascript" src="main.f4002c6365bd7516a919.bundle.js"></script></body></html>