Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create mvvmfx-easydi module #349

Closed
manuel-mauky opened this issue Jan 15, 2016 · 2 comments
Closed

create mvvmfx-easydi module #349

manuel-mauky opened this issue Jan 15, 2016 · 2 comments
Labels
Milestone

Comments

@manuel-mauky
Copy link
Collaborator

manuel-mauky commented Jan 15, 2016

At the moment we have modules for CDI and guice. In addition to this we could create a module for EasyDI too so that projects with this di framework can be easily created.

This should be relatively easy to be done as EasyDI needs far less boilerplate code in comparison to CDI and guice.

@manuel-mauky manuel-mauky added this to the 1.5.0 milestone Jan 15, 2016
@manuel-mauky manuel-mauky modified the milestones: 1.6.0, 1.5.0 Apr 28, 2016
manuel-mauky added a commit that referenced this issue Jul 4, 2016
- renamed `configureBindings` method to `initEasyDi`. This better fits the actual use cases for this method and matches the naming of the `initMvvmfx` method.
#349
@manuel-mauky
Copy link
Collaborator Author

I've renamed the method configureBindings to initEasyDi.
This has 3 reasons:

  1. It better matches what this method is used for. To configure bindings is the main purpose, however it can also be used to get dependency instances that are needed in the app class. As you can't use constructor injection in the app class, this is the only possible alternative.
  2. the term "Binding" can be missleading in the context of JavaFX app.
  3. The method for initialization of mvvmFX is named initMvvmFX. In the Guice module the method to configure modules is named initGuiceModules. So the new naming better matches existing livecycle methods.

@mainrs
Copy link
Contributor

mainrs commented Sep 13, 2016

Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants