Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous DelegateCommand does not executecallbacks #310

Closed
sideisra opened this issue Oct 29, 2015 · 1 comment
Closed

Synchronous DelegateCommand does not executecallbacks #310

sideisra opened this issue Oct 29, 2015 · 1 comment
Labels
Milestone

Comments

@sideisra
Copy link
Contributor

When using DelegateCommand in synchronous mode the callback methods "succeeded" and "failed" are not called after execution of the "action" method. When using DelegateCommand in ansynchronous mode these methods are called like using plain Task and Service.

It is confusing that these methods are not called just because the DelegateCommand is switched to synchronous mode.

new DelegateCommand(<action supplier definition>, true); // callbacks will be executed
new DelegateCommand(<action supplier definition>, false); // callbacks won't be executed
@manuel-mauky
Copy link
Collaborator

Reopend because the implementation forces the execution of the command on the UI thread which is a breaking change and bad for unit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants