Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDI/Guice: make primary stage injectable #130

Closed
manuel-mauky opened this issue Aug 29, 2014 · 1 comment
Closed

CDI/Guice: make primary stage injectable #130

manuel-mauky opened this issue Aug 29, 2014 · 1 comment
Labels
CDI Feature Guice

Comments

@manuel-mauky
Copy link
Collaborator

In some cases it would be useful to be able to inject the primary stage.
For example when you create a new window you need the root stage to initialize the owner and modality.
@manuel-mauky
Copy link
Collaborator Author

With commit b9b63c3 this is implemented for CDI. I've introduced a method makePrimaryStageInjectable in the MvvmfxCdiApplication class, that can be called from the start method.

But maybe there is a better way of doing this.

@manuel-mauky manuel-mauky mentioned this issue Sep 25, 2014
Closed
manuel-mauky added a commit that referenced this issue Sep 26, 2014
@manuel-mauky
#130 make start method of CDI module final
2e16944 
Making the default start method in the MvvmfxCdiApplication class final and do the init logic for primary Stage injection there instead of the old `makePrimaryStageInjectable` method.
This way it's not the task of the user anymore to think about injection of the primary stage.

Instead of the default `start` method we have now a new `startMvvmfx` method. This is equal to the mvvmfx-guice module. See issue #136 for a discussion of this change
manuel-mauky added a commit that referenced this issue Sep 26, 2014
@manuel-mauky
#130 fix build breaker by adding JUnit forkmode to maven config
90aef6d
manuel-mauky added a commit that referenced this issue Oct 1, 2014
@manuel-mauky
Merge pull request #139 from sialcasa/#130_primary_stage_injectable
f00df16 
#130 primary stage injectable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CDI Feature Guice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manuel-mauky