Removed autostart of xdebug #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you is released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my previous PR i've copied the default settings for the xdebug configuration from https://github.com/devcontainers/features.
The configuration works, but will provide a lot of noise in the stdout if you do not have an xdebug listener enabled. In some cases (like PHPUnit tests) these noises are really distracting. The configuration in question is
xdebug.start_with_request, which is now configured withyes.The default configuration of xdebug.start_with_request will take
trigger, which is in my opinion a better option than the current value.So in this PR i've removed the configuration.