Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dezer of QueryRowsEvent. #124

Closed
chenyun opened this issue Oct 14, 2016 · 5 comments
Closed

Dezer of QueryRowsEvent. #124

chenyun opened this issue Oct 14, 2016 · 5 comments

Comments

@chenyun
Copy link
Contributor

chenyun commented Oct 14, 2016

https://dev.mysql.com/doc/internals/en/rows-query-event.html
The length of RowsQueryEvent is not 1 byte coded, the length is ignored actually!
The body is EOF coded string .

@shyiko
Copy link
Owner

shyiko commented Oct 14, 2016

@chenyun Thank you! I'll include the fix in 0.5.1 (which will be released in a few day once PR for #122 is merged in).

shyiko added a commit that referenced this issue Oct 18, 2016
@shyiko
Copy link
Owner

shyiko commented Oct 18, 2016

@chenyun 0.5.1 released.

@shyiko shyiko closed this as completed Oct 18, 2016
@chenyun
Copy link
Contributor Author

chenyun commented Oct 21, 2016

@shyiko There is a new problem: If you use a very huge Insert which is larger than MaxPacketSize(16m), The RowsQueryEvent will be splitted into several Packet, so , the underline dezer logic should change a bit.
Here are some details:
The normal packet is:
3byte length
1byte seq
1byte marker
PacketBody{
19 byte header
header-lengthed byte body
0 or 4 byte checksum
}
In multi packet senario, ONLY the first packet will contain the 1 byte marker , ONLY the last packet will contain the 0 or 4 byte checksum. These packet shuld be concatented to a whole packet.
And I think the Query event can be multi-packet if you wrote a huge function.

@shyiko
Copy link
Owner

shyiko commented Oct 21, 2016

@chenyun
Copy link
Contributor Author

chenyun commented Oct 22, 2016

@shyiko Great! I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants