Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network throttling and device user agent configs #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bmcminn
Copy link
Contributor

@bmcminn bmcminn commented Mar 31, 2016

Fix #5

EDIT:

@shyiko
Copy link
Owner

shyiko commented Apr 1, 2016

Good work! Would you mind removing console.log calls and rebase the branch (right now I can't merge it in due to "This branch has conflicts that must be resolved")?

Also, where does src/profiles/devices.js & src/profiles/networks.js data come from? Thank you.

@bmcminn
Copy link
Contributor Author

bmcminn commented Apr 1, 2016

Alright, finally got the rebase worked out.

Also, the src/profiles data was extrapolated from the latest Chrome throttling and UA device configs in dev tools.

@bmcminn bmcminn force-pushed the master branch 2 times, most recently from 150cd25 to 3562358 Compare April 1, 2016 08:16
@shyiko
Copy link
Owner

shyiko commented Apr 2, 2016

I propose we take list of devices from here. What do you think?

@shyiko
Copy link
Owner

shyiko commented Apr 2, 2016

Also, download/upload throttling is calculated differently. See here.

@bmcminn
Copy link
Contributor Author

bmcminn commented Apr 3, 2016

I like that idea. Just added those defs verbatim to src/profiles/devices.js.

I also went ahead and fixed up a few other things and updated the PR description. I think this feature is ready to close now.

@bmcminn bmcminn force-pushed the master branch 7 times, most recently from c04e2b9 to 825fd37 Compare April 3, 2016 08:21
…ent config; added better device size and orientation logic; more commentary
@shyiko
Copy link
Owner

shyiko commented Apr 3, 2016

Hey man. Unfortunately it looks like this PR will have to wait. My laptop won't turn on :) Will get back to it as soon as I have it fixed.

@bmcminn bmcminn changed the title Added network throttling and device user agent configs Add network throttling and device user agent configs Apr 5, 2016
@bmcminn
Copy link
Contributor Author

bmcminn commented Apr 7, 2016

Hey @shyiko any update on your laptop situation?

@shyiko
Copy link
Owner

shyiko commented Apr 11, 2016

@bmcminn I'm getting it back tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thoughts on leveraging network throttling and user agents?
2 participants