-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network throttling and device user agent configs #6
base: master
Are you sure you want to change the base?
Conversation
Good work! Would you mind removing console.log calls and rebase the branch (right now I can't merge it in due to "This branch has conflicts that must be resolved")? Also, where does src/profiles/devices.js & src/profiles/networks.js data come from? Thank you. |
Alright, finally got the rebase worked out. Also, the |
150cd25
to
3562358
Compare
I propose we take list of devices from here. What do you think? |
Also, download/upload throttling is calculated differently. See here. |
I like that idea. Just added those defs verbatim to I also went ahead and fixed up a few other things and updated the PR description. I think this feature is ready to close now. |
c04e2b9
to
825fd37
Compare
…ent config; added better device size and orientation logic; more commentary
Hey man. Unfortunately it looks like this PR will have to wait. My laptop won't turn on :) Will get back to it as soon as I have it fixed. |
Hey @shyiko any update on your laptop situation? |
@bmcminn I'm getting it back tomorrow morning. |
Fix #5
EDIT:
-A
(user agent) with argument validation-Y
(network throttling) with argument validationuser-agent
string override when using-A
--landscape
which forces device orientation to landscapesrc/profiles/devices.js
based on Chromium device profile definitions:src/profiles/networks.js
based on Chromium network speed definitions: