Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): add typescipt and esmodule support for shuvi.config.js #228

Merged
merged 1 commit into from
Dec 21, 2021
Merged

feat(service): add typescipt and esmodule support for shuvi.config.js #228

merged 1 commit into from
Dec 21, 2021

Conversation

Repraance
Copy link
Contributor

  • add typescipt and esmodule support for shuvi.config.js
  • export a method defineConfig for inferring types

liximomo
liximomo approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@liximomo liximomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liximomo liximomo merged commit ee9887a into shuvijs:dev Dec 21, 2021
@liximomo liximomo deleted the feature/shuviconfigjssupport branch December 21, 2021 08:01
liximomo pushed a commit that referenced this pull request Jun 11, 2022
@Repraance
feat(service): add typescipt and esmodule support for shuvi.config.js (…
3ca7b2a 
…#228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liximomo liximomo liximomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Repraance @liximomo