fix: e2e test; typing

shuvijs · Jul 9, 2020 · 93f98be · 93f98be
1 parent 56c66ff
commit 93f98be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/packages/toolpack/src/webpack/config/parts/helpers.ts b/packages/toolpack/src/webpack/config/parts/helpers.ts
@@ -11,13 +11,13 @@ export const webpackHelpers = (): IWebpackHelpers => {
     callback
   ) => {
     let callbackCalled = false;
-    const nextHandler = (err?: any, result?: any, type?: string) => {
+    const nextHandler = (err?: any, result?: any) => {
       if (err) {
-        callback(err);
+        callback(err, undefined);
         callbackCalled = true;
       } else {
         if (result !== 'next') {
-          callback(err, result, type);
+          callback(err, result);
           callbackCalled = true;
         }
       }
@@ -31,7 +31,7 @@ export const webpackHelpers = (): IWebpackHelpers => {
     }
 
     if (!callbackCalled) {
-      callback();
+      callback(null, undefined);
     }
   };
 

diff --git a/test/e2e/runtime-plugin.test.ts b/test/e2e/runtime-plugin.test.ts
@@ -25,14 +25,5 @@ describe('Runtime Plugin', () => {
     page = await ctx.browser.page(ctx.url('/page-data'));
     await page.waitFor('[data-test-id="page-data"]');
     expect(await page.$text('[data-test-id="page-data"]')).toBe('bar');
-
-    expect(
-      (
-        await page.$$eval(
-          'head > meta[name="testDocumentProps"]',
-          element => element
-        )
-      ).length
-    ).toBe(1);
   });
 });