Fix: dependencies compiled with incompatible versions of rustc

[oddgrd]

Crates with a rust-toolchain.toml override would forcibly install that toolchain and use it to compile these crates, leading to certain crates being compiled with different versions of rustc.

Setting the override with RUSTUP_TOOLCHAIN trumps the .toml override. Tested by deploying an axum hello-world app with dashmap, as well as a serenity app with the cache feature (which pulls in dashmap).

[chesedo]

We can merge if you are happy with the question @oddgrd

[sd2k]

FYI I still experienced this issue with axum-macros and had to manually patch to a fork without rust-toolchain using [patch.crates-io] (i.e. this commit works (w.r.t this issue), but the previous commit doesn't).

[oddgrd]

Hey! This fix hasn't been deployed to production yet, so you'll need the work-around for a little bit longer. By the way, looking at your cargo.toml comments, we do support path dependencies since 0.8.0.

[sd2k]

Ah gotcha, that makes sense.

It might be workspace dependencies, not path dependencies, that aren't working for me then 🤔 uncommenting the { workspace = true } dependencies gives:

2023-01-01T20:40:19.707969953Z ERROR {error="Build error: failed to parse manifest at `/opt/shuttle/shuttle-builds/recipe-shuttle/Cargo.toml`"} shuttle_deployer::deployment::queue: service build encountered an error

if I change all of those { workspace = true } to { path = "../whatever" } I see:

2023-01-02T13:51:44.004967421Z ERROR {error="Build error: failed to get `recipe-db` as a dependency of package `recipe-shuttle-fd2affd4-0a12-43ae-9a8b-c8d5875887a3 v0.1.0 (/opt/shuttle/shuttle-builds/recipe-shuttle)`"} shuttle_deployer::deployment::queue: service build encountered an error

I suspect this should be in a separate issue though - lmk if these are unexpected issues and I'll create one 😄

[oddgrd]

Hmm, it should work. 🤔 What is your cargo shuttle --version?

[sd2k]

❯ cargo shuttle --version
cargo-shuttle 0.8.1

🤔

[chesedo]

For the workspace dependencies, we aren't currently archiving the entire workspace but only the single crate. This is why the paths don't work and why the workspace toml can't be found (parsed). I've created a new issue for this #564