Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sidebar styling #208

Merged
merged 3 commits into from
Oct 30, 2024
Merged

add sidebar styling #208

merged 3 commits into from
Oct 30, 2024

Conversation

faheelsattar
Copy link
Contributor

Closes #118

@faheelsattar faheelsattar self-assigned this Oct 30, 2024
ylembachar
ylembachar reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ylembachar ylembachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sidebar margins and padding still need to be corrected. Please see the difference below and check the Figma design for the exact values. Thanks.
Screenshot 2024-10-30 at 13 52 24
Screenshot 2024-10-30 at 13 52 30

@faheelsattar faheelsattar merged commit edde58c into staging Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylembachar ylembachar ylembachar approved these changes

@blockchainluffy blockchainluffy Awaiting requested review from blockchainluffy

Assignees

@faheelsattar faheelsattar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faheelsattar @ylembachar