[Bug]: span tags of type int64 may lose precision jaegertracing#3958

Signed-off-by: Shubham Sawaiker <[email protected]> Signed-off-by: shubbham1215 <[email protected]>
shubbham1215 · Mar 5, 2023 · aa8ec83 · aa8ec83
1 parent 40b1828
commit aa8ec83
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/model/converter/json/fixtures/domain_01.json b/model/converter/json/fixtures/domain_01.json
@@ -57,6 +57,11 @@
           "vType": "FLOAT64",
           "vFloat64": 72.5
         },
+        {
+          "key":"javascript_limit",
+          "vType":"INT64",
+          "vInt64":9223372036854775222
+        },
         {
           "key": "blob",
           "vType": "BINARY",

diff --git a/model/converter/json/fixtures/ui_01.json b/model/converter/json/fixtures/ui_01.json
@@ -62,6 +62,11 @@
           "type": "float64",
           "value": 72.5
         },
+        {
+          "key":"javascript_limit",
+          "vType":"INT64",
+          "vInt64":9223372036854775222
+        },
         {
           "key": "blob",
           "type": "binary",

diff --git a/model/converter/json/from_domain.go b/model/converter/json/from_domain.go
@@ -16,12 +16,18 @@
 package json
 
 import (
+	"fmt"
 	"strings"
 
 	"github.com/jaegertracing/jaeger/model"
 	"github.com/jaegertracing/jaeger/model/json"
 )
 
+const (
+	js_limit_max = 9007199254740991
+	js_limit_min = -9007199254740991
+)
+
 // FromDomain converts model.Trace into json.Trace format.
 // It assumes that the domain model is valid, namely that all enums
 // have valid values, so that it does not need to check for errors.
@@ -122,6 +128,10 @@ func (fd fromDomain) convertKeyValues(keyValues model.KeyValues) []json.KeyValue
 			value = kv.Bool()
 		case model.Int64Type:
 			value = kv.Int64()
+			if kv.Int64() > js_limit_max || kv.Int64() < js_limit_min {
+				kv.VType = 0
+				value = fmt.Sprintf("%d", value)
+			}
 		case model.Float64Type:
 			value = kv.Float64()
 		case model.BinaryType: