Skip to content
This repository has been archived by the owner on Feb 10, 2019. It is now read-only.

Scroll To Top Button #34

Merged
merged 1 commit into from
Nov 22, 2015
Merged

Scroll To Top Button #34

merged 1 commit into from
Nov 22, 2015

Conversation

mezmi
Copy link
Contributor

@mezmi mezmi commented Nov 22, 2015

Added 'Scroll To Top' function that injects a [ ▲ TOP ] button into the navbar if TOP > 100px

This requires the navbar to be fixed to the top as I didn't want to cover up any content

Added 'Scroll To Top' function that injects a [TOP ▲] button into the navbar if TOP > 100px
@shu8
Copy link
Owner

shu8 commented Nov 22, 2015

@enkimatt that's a nice, invisible, issue you made there :P

@mezmi
Copy link
Contributor Author

mezmi commented Nov 22, 2015

Ahhh crap! I'm honestly still figuring out how this all works.

@shu8
Copy link
Owner

shu8 commented Nov 22, 2015

@enkimatt lol no problem! I was saying: before making a pull request for a new feature, or even a bug fix, just make an issue first.

The only reason is, in the future, it helps looking at when new features were added! :)

But it's not necessary at all! And I'm guilty of not doing so myself :P

I will merge this, just need to sort out some conflicts :)

@mezmi
Copy link
Contributor Author

mezmi commented Nov 22, 2015

@shu8 Okay, cool. I will do that from now on.

@shu8 shu8 merged commit a03e0ae into shu8:develop Nov 22, 2015
@shu8
Copy link
Owner

shu8 commented Nov 22, 2015

@enkimatt merged :)

Make sure you pull the latest version!

and BTW when you add features, please could you add them at the bottom of the functionsToCall object? (It's just the way I've been doing it from the beggining)

I seriously need to make a wiki :P

@mezmi
Copy link
Contributor Author

mezmi commented Nov 22, 2015

Yeah, sorry about that, I'll all them to the bottom of the list from now on.

@shu8
Copy link
Owner

shu8 commented Nov 22, 2015

@enkimatt no problem! Thanks :) I'm making the wiki now :)

@shu8
Copy link
Owner

shu8 commented Nov 22, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants