Fixed quiet mode #20
Merged
Fixed quiet mode #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! I'll get this merged right away. |
shssoichiro
pushed a commit
that referenced
this pull request
Mar 4, 2016
|
Do you think it would be necessary/useful to enable |
|
I think so, yes, since most people would probably use -q so the only thing in stdout is the image itself and nothing more so they don't have to parse it and remove the text. So I think maybe you should enable quiet mode when stdout is also enabled |
|
Alternatively the program could output status messages to stderr instead of stdout, like curl does. |
|
This is true. Maybe that would be a better option. |
shssoichiro
pushed a commit
that referenced
this pull request
Mar 4, 2016
Makes it friendlier with --stdout option See #20 for discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't seem to figure out why my images were coming out as corrupted even though they were fine. Turns out oxipng was still printing information about the image such as the reduction even though it was in --quiet mode and --stdout, and that broke the image.
Anyways this does some additional checking for opts.verbosity before it prints stuff