Skip to content

Commit

Permalink
Tweak alpha factor in luma sort
Browse files Browse the repository at this point in the history
  • Loading branch information
andrews05 committed Jun 26, 2023
1 parent 633b59c commit bac44fa
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/reduction/palette.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ pub fn sorted_palette(png: &PngImage) -> Option<PngImage> {
enumerated.sort_by(|a, b| {
// Sort by ascending alpha and descending luma
let color_val = |color: &RGBA8| {
((color.a as i32) << 18)
let a = i32::from(color.a);
// Put 7 high bits of alpha first, then luma, then low bit of alpha
// This provides notable improvement in images with a lot of alpha
((a & 0xFE) << 18) + (a & 0x01)
// These are coefficients for standard sRGB to luma conversion
- i32::from(color.r) * 299
- i32::from(color.g) * 587
Expand Down

0 comments on commit bac44fa

Please sign in to comment.