Implemented ArchiveMavenAssembler as a new API of MavenImporter #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MavenImporter (which was deprecated)
the integration tests are implemented inside of the impl-maven-archive module
|
Not sure If I should wait with releasing 3.0.0-Alpha1 untill the whole new API is implemented or if I should release the master branch as it is now and add the new API into the Alpha2. WDYT @ALRubinger ? |
| @@ -0,0 +1,91 @@ | |||
| /* | |||
| * JBoss, Home of Professional Open Source | |||
| * Copyright 2012, Red Hat Middleware LLC, and individual contributors | |||
There was a problem hiding this comment.
We actually shouldn't be putting copyright notices on source files anymore. :) Recommend updating IDE templates.
There was a problem hiding this comment.
Copy-pasted from MavenImporter class. I didn't know about it - is there some document/email/article about it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains only the Maven part - the Gradle one will be implemented ASAP.
Please do not merge this branch for now - I sent it only for reviewing and to open a discussion if anything should be changed. It probably also needs more testing and code/javadoc polishing