Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speedtest struct which contains the global variables used #62

Merged
merged 4 commits into from
Feb 20, 2022

Conversation

mr-linch
Copy link
Contributor

Thanks for useful package! 🤝
We need to bench multiple proxies concurrently. It's not possible in current implementation without dirty hacks.
So, instead of use global http.DefaultClient we add struct speedtest.Speedtest which contains it in itself and allows you to redefine. Backward compatibility is maintained, we use method like in math/rand package.

@showwin
Copy link
Owner

showwin commented Feb 20, 2022

@mr-linch Thank you for great PR and sorry for my late response 🙇
LGTM 👍

@showwin showwin merged commit 4e10a07 into showwin:master Feb 20, 2022
@showwin showwin self-requested a review February 20, 2022 02:07
showwin added a commit that referenced this pull request Feb 20, 2022
showwin added a commit that referenced this pull request Feb 20, 2022
@showwin showwin mentioned this pull request Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants