Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core table functionality not working as expected? #179

Closed
grofit opened this issue Jul 21, 2015 · 8 comments
Closed

Core table functionality not working as expected? #179

grofit opened this issue Jul 21, 2015 · 8 comments
Assignees

Comments

@grofit
Copy link

grofit commented Jul 21, 2015

So I have got 1.2.0 and have enabled tables option and used the example markup

| *foo* | **bar** | ~~baz~~ |
|:------|:-------:|--------:|
| 100   | [a][1]  | ![b][2] |

and it generates

Image

Now I was expecting that the headers would have their * and ~~ parsed into styling, however it just translates them directly, same with the output content. I am assuming it should be taking the styling in the headers into account?

@grofit grofit changed the title Core table functionality not working as expected Core table functionality not working as expected? Jul 21, 2015
@tivie
Copy link
Member

tivie commented Jul 21, 2015

Actually, this is by design since it follows md tables spec1. However spec 2 does allow span elements in the titles. see https://michelf.ca/projects/php-markdown/dingus/

I will add a milestone and implement it in a future release.

@grofit
Copy link
Author

grofit commented Jul 21, 2015

no worries, it just seemed odd that the example on the website included this if it is not supported.

@tivie
Copy link
Member

tivie commented Jul 21, 2015

Ah, good catch

@tivie
Copy link
Member

tivie commented Jul 21, 2015

Fixed it in the README.md

tivie added a commit that referenced this issue Jul 22, 2015
Partial, add html
tivie added a commit that referenced this issue Jul 22, 2015
@tivie
Copy link
Member

tivie commented Jul 22, 2015

give it a shot

#180

@grofit
Copy link
Author

grofit commented Jul 22, 2015

Just got the latest showdown.js from the dist folder on master and it still seems to be acting the same, the commit says its against master, could it just be that the dist was not updated?

@tivie
Copy link
Member

tivie commented Jul 22, 2015

you need to use the tivie-patch-1 branch https://github.com/showdownjs/showdown/tree/tivie-patch-1

@grofit
Copy link
Author

grofit commented Jul 22, 2015

ah kk, will give it another go shortly, thanks again for the quick turn around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants