-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core table functionality not working as expected? #179
Comments
Actually, this is by design since it follows md tables spec1. However spec 2 does allow span elements in the titles. see https://michelf.ca/projects/php-markdown/dingus/ I will add a milestone and implement it in a future release. |
no worries, it just seemed odd that the example on the website included this if it is not supported. |
Ah, good catch |
Fixed it in the README.md |
give it a shot |
Just got the latest showdown.js from the dist folder on master and it still seems to be acting the same, the commit says its against master, could it just be that the dist was not updated? |
you need to use the tivie-patch-1 branch https://github.com/showdownjs/showdown/tree/tivie-patch-1 |
ah kk, will give it another go shortly, thanks again for the quick turn around. |
feat(subParser/tables.js): add support for md span elements in table headers Closes #179
So I have got 1.2.0 and have enabled tables option and used the example markup
and it generates
Now I was expecting that the headers would have their
*
and~~
parsed into styling, however it just translates them directly, same with the output content. I am assuming it should be taking the styling in the headers into account?The text was updated successfully, but these errors were encountered: