Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(subParsers/italicsAndBold): fix underscores not being correctly p…
…arsed when used in conjunction with literalMidWordsUnderscores option
- Loading branch information
c9e85f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE8 is throwing "Expected ']' in regular expression" (both old and new expression - so this commit did not introduce the issue)
c9e85f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hummm...
Maybe changing
[^]
with[\s\S]
.@butchmarshall I can't test on IE8 right now... do you mind testing it for me please?
c9e85f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't crash anymore with that change @tivie! I don't know if the regexp is still performing the same operation though - does this function have tests?
c9e85f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all parsers and options have specific tests. You just need to run the test suite.
Those regexps should be interchangeable.