fix(tables): pipe character in code spans no longer breaks table

A code span with a pipe character no longer incorrectly breaks the cell table. Closes #465
showdownjs · Nov 23, 2017 · 0c933a0 · 0c933a0
1 parent f4f63c5
commit 0c933a0
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 5 deletions.
diff --git a/dist/showdown.js b/dist/showdown.js
diff --git a/dist/showdown.js.map b/dist/showdown.js.map
diff --git a/dist/showdown.min.js b/dist/showdown.min.js
diff --git a/dist/showdown.min.js.map b/dist/showdown.min.js.map
diff --git a/src/subParsers/tables.js b/src/subParsers/tables.js
@@ -61,14 +61,16 @@ showdown.subParser('tables', function (text, options, globals) {
   function parseTable (rawTable) {
     var i, tableLines = rawTable.split('\n');
 
-    // strip wrong first and last column if wrapped tables are used
     for (i = 0; i < tableLines.length; ++i) {
+      // strip wrong first and last column if wrapped tables are used
       if (/^ {0,3}\|/.test(tableLines[i])) {
         tableLines[i] = tableLines[i].replace(/^ {0,3}\|/, '');
       }
       if (/\|[ \t]*$/.test(tableLines[i])) {
         tableLines[i] = tableLines[i].replace(/\|[ \t]*$/, '');
       }
+      // parse code spans first, but we only support one line code spans
+      tableLines[i] = showdown.subParser('codeSpans')(tableLines[i], options, globals);
     }
 
     var rawHeaders = tableLines[0].split('|').map(function (s) { return s.trim();}),

diff --git a/test/features/tables/#465.code-spans-with-pipes-break-table.html b/test/features/tables/#465.code-spans-with-pipes-break-table.html
@@ -0,0 +1,14 @@
+<table>
+    <thead>
+    <tr>
+        <th>PowerShell command</th>
+        <th>Example</th>
+    </tr>
+    </thead>
+    <tbody>
+    <tr>
+        <td>Get-Service</td>
+        <td><code>Get-Service | Stop-Service -WhatIf</code></td>
+    </tr>
+    </tbody>
+</table>
diff --git a/test/features/tables/#465.code-spans-with-pipes-break-table.md b/test/features/tables/#465.code-spans-with-pipes-break-table.md
@@ -0,0 +1,3 @@
+|PowerShell command|Example|
+|--|--|
+|Get-Service|`Get-Service | Stop-Service -WhatIf`|