-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit for this **EXPERIMENTAL** branch #93
base: master
Are you sure you want to change the base?
Conversation
Adds `ShotgunMulti` object which inherits from Shotgun and is returned when setting the multi_thread=True parameter when instantiating Shotgun. This object uses the requests module instead of httplib2/urllib. Adds callbacks to the upload() and download_attachment() methods which receive a ShotgunProgressMonitor object for use when handling progress info. More to come.
This is exciting! @sgsteph should watch this space :) |
I definetely do ;) Stéphane Deverly
|
heh... lots of this is about to change :). Moving away from the subclassing and going to make this much more independent. Updates coming hopefully very soon! |
Very exciting to see these changes! Chris Sent from my iPad
|
A quick heads up that I had issues with requests.get and https://sg-media-usor-01.s3.amazonaws.com urls and ended up having verify=False for my download requests. By default, verify is True I think. |
@sgsteph interesting. I did not run into any issues on my end. Were the issues simply verification failures or something else? |
The error was :
|
Not for merging. just for review.
Adds
ShotgunMulti
object which inherits from Shotgun and is returned when setting the multi_thread=True parameter when instantiating Shotgun. This object uses the requests module instead of httplib2/urllib.Adds callbacks to the upload() and download_attachment() methods which receive a ShotgunProgressMonitor object for use when handling progress info.
More to come.