Fix failure to set initially ungettable volume options like client.ssl #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear why but attempting to get client.ssl before it is set results in an error and an exit status of 2. This is different to getting a fictional option like foo.bar, which results in a different error and an exit status of 1. Let's prevent an exit status of 2 from raising an exception and mark the resource as non-existent in this case. After resetting client.ssl, it returns to its ungettable state so do not perform subsequent resets when the resource is non-existent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear why but attempting to get
client.sslbefore it is set results in an error and an exit status of 2. This is different to getting a fictional option likefoo.bar, which results in a different error and an exit status of 1.Let's prevent an exit status of 2 from raising an exception and mark the resource as non-existent in this case.
After resetting
client.ssl, it returns to its ungettable state so do not perform subsequent resets when the resource is non-existent.