Allow use gluster recipe on already existed filesystem #77
Conversation
| @@ -4,7 +4,7 @@ | |||
| license 'Apache 2.0' | |||
| description 'Installs and configures Gluster servers and clients' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '5.1.0' | |||
| version '5.1.1' | |||
There was a problem hiding this comment.
why? I think that's a "feature" fix, so it's easier to bump version to point which version works :)
There was a problem hiding this comment.
Version bumps happen when a release it cut
| size volume_values['size'] | ||
| filesystem filesystem | ||
| mount_point "#{node['gluster']['server']['brick_mount_path']}/#{volume_name}" | ||
| if node['gluster']['server']['disks'].any? |
There was a problem hiding this comment.
Can you add an else to this with a warning log saying that no LVM setup will be done?
| end | ||
| end | ||
|
|
||
| directory "#{node['gluster']['server']['brick_mount_path']}/#{volume_name}" do |
There was a problem hiding this comment.
Have you confirmed this will not have any affect on LVM based mounts?
There was a problem hiding this comment.
i'ts just creating directory. If directory already exists - nothing will change. But - i can put it into conditional block.
| @@ -92,6 +103,7 @@ | |||
| # Create option string | |||
| force = false | |||
| options = '' | |||
| force = true if node['gluster']['server']['disks'].empty? | |||
There was a problem hiding this comment.
Why is force need here? What error does gluster throw?
There was a problem hiding this comment.
force is needed only when gluster is creating on root partition/volume (for example on kitchen ;). But i dont know how to easy check if there is that case. I think about conditional "force" option for volume configuration.
There was a problem hiding this comment.
df /path/to/dir | tail -1 then check the last part of the array
There is probably other solutions too
Example outside the context of chef
[3] pry(main)> `df /etc | tail -1`.chomp.split[-1]
=> "/"
[4] pry(main)>
|
Is that better? :-) |
shortdudey123
changed the title
|
squashed :-) |
No description provided.