Allow host check to match when hostname is listed under 'Other names' #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| license 'Apache 2.0' | |||
| description 'Installs and configures Gluster servers and clients' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '5.0.0' | |||
| version '5.0.1' | |||
There was a problem hiding this comment.
Can you revert the version bump :)
|
Can you rebase on top of master and squash your commits? Then tests should pass. Thanks!! |
|
Thanks for the quick reply! I've squashed the commits. |
shortdudey123
added a commit
that referenced
this pull request
Mar 8, 2016
Allow host check to match when hostname is listed under 'Other names'
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues where the
gluster peer probecommand was returning the peer's IP address as the hostname and the actual hostname under "Other names".I modified the command to filter out the 'Other names' line so that the 'Connected' line would always be above it. Then we have grep return two lines after a match and one line before. This was to prevent a situation where the command didn't return nodes that have 'other names' and a connected message for a prior node would appear two lines above the node being probed.
I'd be happy to try out other approaches if there might be a cleaner method.