allow hostname for older versions of chef-server #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbrookes
force-pushed
the
fqdn-or-hostname
branch
from
08a63d7 to
3bc71d0
Compare
| if brick_count < volume_values['replica_count'] | ||
| Chef::Log.warn("Correct number of bricks not available for volume #{volume_name}. Skipping...") | ||
| requiredBricks = (volume_values['replica_count'] * volume_values['peers'].count) | ||
| if brick_count != requiredBricks |
There was a problem hiding this comment.
Can you elaborate on this?
If i am reading it right this would not work. With an RF of 3 with 3 nodes so 1 brick per node, requiredBricks would be 9 but you only have 3 bricks.
|
Whoops, my mistake, I had changed the wrong if statement. I've moved it to the correct one now. |
philbrookes
force-pushed
the
fqdn-or-hostname
branch
3 times, most recently
from
d3abc8e to
9b088f3
Compare
|
cool, good idea. I've added that too. |
shortdudey123
added a commit
that referenced
this pull request
Aug 10, 2015
allow hostname for older versions of chef-server
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Excellent cookbook!
just a few minor tweaks:
On older versions of chef-server
node['fqdn']does not seem to be set:This change will allow those older ones to use this cookbook and check against
hostnameinstead, iffqdnfails for some reason.I also slightly modified one of the error messages, when I was trying to debug an issue I was having :)