Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sorting countries #772

Closed
wants to merge 1 commit into from
Closed

Conversation

tinect
Copy link
Contributor

@tinect tinect commented Apr 23, 2020

1. Why is this change necessary?

Currently...:

  • the sorting of countries is failing, when the current saleschannel language should use inherited translation
  • the sorting doesn't respect current translation

2. What does this change do, exactly?

Respect translated value

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9053

Please use this issue to track the state of your pull request.

@lernhart lernhart self-assigned this Jun 4, 2020
@tinect tinect deleted the fixCountrySorting branch June 4, 2020 13:30
@mitelg
Copy link
Member

mitelg commented Jun 4, 2020

thanks for your contribution @tinect 👍 🎉 💙

@mitelg mitelg added Accepted and removed Scheduled labels Jun 4, 2020
FalkoHilbert pushed a commit to FalkoHilbert/platform that referenced this pull request Jun 7, 2020
shopwareBot pushed a commit to shopware/core that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants