Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-client): improved error handling #316

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jul 12, 2023

Description

Thanks to community discussion: https://shopwarecommunity.slack.com/archives/C02TZE6UCJZ/p1689002187992129

Improved error handling for API client. Examples:
image

not catched error it still informative:
image

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jul 12, 2023 9:17am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 12, 2023 9:17am

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the functionality itself, I like to see the example included in README.md 💙 pure joy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants