Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-demo): leverage edge cache #309

Merged
merged 13 commits into from
Jul 11, 2023
Merged

feat(vue-demo): leverage edge cache #309

merged 13 commits into from
Jul 11, 2023

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jul 10, 2023

Description

Type of change

edge cache leverage:

  • add cache to public websites, edge cache should be hit
  • Ensure session context is not cached
  • CSR client-sensitive pages like checkout, account page

Additionaly compare lighthouse:

image

@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 0:29am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 0:29am

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect to have it working so fast 🚀
+ loading=lazy didn't broke the LCP in overall score

one note: please add a corresponding section in README.md in this or another PR 🙏🏻 to give an overview for someone "uninitiated" 😎

@patzick patzick merged commit 84a7fe6 into main Jul 11, 2023
@patzick patzick deleted the feat/leverage-edge-cache branch July 11, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants