Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(composables): adding promotion code #1099

Merged
merged 8 commits into from
Jul 18, 2024
Merged

fix(composables): adding promotion code #1099

merged 8 commits into from
Jul 18, 2024

Conversation

mdanilowicz
Copy link
Collaborator

Description

Fix for adding promotion code

Type of change

ToDo's

Screenshots (if applicable)

Additional context

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Jul 18, 2024 11:49am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 18, 2024 11:49am

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1099 will not alter performance

Comparing fix/promotion-code (b415ec6) with fix/promotion-code (8dec568)

Summary

✅ 9 untouched benchmarks

patzick
patzick requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the place of the fix to not make it disappear after the regeneration.

  1. change storeAPiTypes.overrides.ts
  2. run pnpm run generate-types in api-client package
  3. rerun pnpm run generate-types in the project root directory

packages/api-client/api-types/storeApiTypes.d.ts Outdated Show resolved Hide resolved
@mdanilowicz mdanilowicz requested a review from patzick July 17, 2024 10:38
patzick
patzick approved these changes Jul 18, 2024
View reviewed changes
.changeset/twenty-drinks-end.md Outdated Show resolved Hide resolved
@patzick patzick merged commit 3bde5fe into main Jul 18, 2024
4 of 6 checks passed
@patzick patzick deleted the fix/promotion-code branch July 18, 2024 11:44
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstala kstala kstala approved these changes

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdanilowicz @patzick @kstala