Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Internal navigation regression #311

Closed
1 task done
patzick opened this issue Jul 11, 2023 · 0 comments · Fixed by #322
Closed
1 task done

[BUG] Internal navigation regression #311

patzick opened this issue Jul 11, 2023 · 0 comments · Fixed by #322
Assignees
@mdanilowicz
Labels
bug Something isn't working

Comments

@patzick
Copy link
Collaborator

patzick commented Jul 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In #230 we introduced i18n, but caused internal navigation regression at the same time. During internal navigation we can see seo-url invocations in the network tab

Expected Behavior

same as: #194 - no seo-url calls during internal navigation

Steps To Reproduce

  1. go to any page
  2. click any navigation link/product cart
  3. seo-url call

Environment

No response

Anything else?

Additionally - @kstala, please provide an e2e test for internal navigation, which fails when it sees store-api/seo-url request
@patzick patzick added the bug Something isn't working label Jul 11, 2023
@mdanilowicz mdanilowicz self-assigned this Jul 13, 2023
@mdanilowicz mdanilowicz moved this to In Progress in Composable Frontends Jul 13, 2023
@mdanilowicz mdanilowicz mentioned this issue Jul 13, 2023
Merged
3 tasks
@patzick patzick mentioned this issue Jul 18, 2023
Merged
patzick added a commit that referenced this issue Jul 18, 2023
@patzick
Merge branch 'main' into feat/GH-311
a5725eb
patzick added a commit that referenced this issue Jul 18, 2023
@patzick
Merge branch 'main' into feat/GH-311
ee3d81c
@github-project-automation github-project-automation bot moved this from In Progress to Done in Composable Frontends Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdanilowicz mdanilowicz

Labels
bug Something isn't working
Projects
Composable Frontends
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add new link builder shopware/frontends
2 participants
@mdanilowicz @patzick