fix: do not fail validation process yet

shopware · Nov 4, 2024 · b550cef · b550cef
1 parent 44be652
commit b550cef
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.changeset/tame-plums-cry.md b/.changeset/tame-plums-cry.md
@@ -0,0 +1,5 @@
+---
+"@shopware/api-gen": patch
+---
+
+Fix process failing on errors to give more time for adoption.
diff --git a/packages/api-gen/src/commands/validateJson.ts b/packages/api-gen/src/commands/validateJson.ts
@@ -203,7 +203,12 @@ export async function validateJson(args: {
     console.error(
       c.red(`Validation failed with ${c.bold(errors.length)} errors.`),
     );
-    process.exit(1);
+    // process.exit(1);
+    console.warn(
+      c.yellow(
+        "Errors found! This command will start failing in the future. Fix the errors from summary. Bypassing process fail for now.",
+      ),
+    );
   } else {
     console.log(c.green("✔️ Validation passed successfully."));
   }

diff --git a/packages/api-gen/src/jsonOverrideUtils.ts b/packages/api-gen/src/jsonOverrideUtils.ts
@@ -95,7 +95,7 @@ export function displayPatchingSummary({
   alreadyApliedPatches: number;
   errors?: string[];
 }) {
-  if (todosToFix.length) {
+  if (!errors?.length && todosToFix.length) {
     console.log(c.yellow("Warnings to fix in the schema:"));
     todosToFix.forEach((todo) => {
       console.log(`${c.yellow("WARNING")}: ${todo[0]}`);