[shopsys] Microservices webserver using nginx + php-fpm #494
Conversation
MattCzerner
commented
Sep 20, 2018
MattCzerner
commented
| Q | A |
|---|---|
| Description, reason for the PR | Microservices were started by symfony integrated server, this is not a good practice for production environment. This PR adds nginx and starts php-fpm during dockerfile build. |
| New feature | No |
| BC breaks | No |
| Fixes issues | |
| Standards and tests pass | Yes |
| Have you read and signed our License Agreement for contributions? | Yes |
There was a problem hiding this comment.
Hello @MattCzerner ,
please squash first and second commit and move third commit into separate PR, thank you.
| STOPSIGNAL SIGTERM | ||
|
|
||
| # allow "www-data" user running "php-fpm" and "nginx" as root (needed during the execution of "docker-after-start") | ||
| RUN apk add --no-cache sudo |
There was a problem hiding this comment.
Please join this apk and apk git with apk for libconv ... you then do not need run again apk --update and it is better because you are not creating necessary layers
There was a problem hiding this comment.
Okay, btw i deleted install of git, seems like i had some misconfiguration on my local computer
| STOPSIGNAL SIGTERM | ||
|
|
||
| # allow "www-data" user running "php-fpm" and "nginx" as root (needed during the execution of "docker-after-start") | ||
| RUN apk add --no-cache sudo |
There was a problem hiding this comment.
Same as with previous comment
MattCzerner
force-pushed
the
ph-mc-microservices-webserver
branch
2 times, most recently
from
f3927ce to
940c9cc
Compare
| @@ -18,8 +18,7 @@ This leanest Symfony version is highly optimized and it is suitable for this typ | |||
| The microservice is responsible for feeding the Elasticsearch by product data so [product search microservice](https://github.com/shopsys/microservice-product-search) can work properly. | |||
|
|
|||
| ## Installation | |||
| Basically, in the Docker container of the microservice, all the dependencies have to be installed using `composer install` and the server has to be started by `php bin/console server:run *:8000`. | |||
| All this is automatically done when the container starts. | |||
| Microservice is installed during `docker-compose up -d` in your `project-base`, during build of image all dependencies gets installed and nginx with php-fpm si configured to allow traffic into microservice. | |||
There was a problem hiding this comment.
The installation of a microservice should be independent of the rest of the framework imo, I would just mention starting the container, without mentioning project-base or docker-compose.
Also, later in this section you left the mention about the native installation of microservices which still recommends using the symfony webserver - but you have uninstalled it in this PR.
There was a problem hiding this comment.
I added commit that fixes this. Can you please look at it? Last commit will be squashed with README.md commit and i will use commit message "Updated documentation to match new state of microservices"
MattCzerner
force-pushed
the
ph-mc-microservices-webserver
branch
3 times, most recently
from
1093289 to
a006a89
Compare
There was a problem hiding this comment.
There were inconsistencies and copy-paste mistakes in the native installation guide. In the Dockerfile sudeoers note, php-fpm wasn't mentioned. I've fixed both in a couple of commits made in the GitHub web UI. Please review them.
Also, there is still a missing artifact after the installed webserver in the second microservice, which was not removed.
| @@ -2,6 +2,5 @@ | |||
|
|
|||
| return [ | |||
| Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true], | |||
| Symfony\Bundle\WebServerBundle\WebServerBundle::class => ['dev' => true], | |||
There was a problem hiding this comment.
It looks like you haven't properly uninstalled the webserver - you still have /.web-server-pid included in the .gitignore... Why don't you use Flex?
- change port from 8000 to 80 in kubernetes services - installation is inspired by official nginx dockerimage - microservices are not dependent on symfony webserver now
MattCzerner
force-pushed
the
ph-mc-microservices-webserver
branch
from
527e7bb to
5c7d47f
Compare
| \ | ||
| # forward request and error logs to docker log collector | ||
| && ln -sf /dev/stdout /var/log/nginx/access.log \ | ||
| && ln -sf /dev/stderr /var/log/nginx/error.log |
There was a problem hiding this comment.
There should be spaces instead of tabs (it's correct in the second Dockerfile).
UPGRADE.md
Outdated
| @@ -18,6 +18,11 @@ There is a list of all the repositories maintained by monorepo, changes in log b | |||
| * [shopsys/microservice-product-search-export] | |||
|
|
|||
| ## [From 7.0.0-beta1 to Unreleased] | |||
| [shopsys/project-base] | |||
There was a problem hiding this comment.
It should be a heading: ### [shopsys/project-base].
PetrHeinz
changed the title
