[shopsys] entities are refreshed after product visibility recalculations

[grossmannmartin]

Q	A
Description, reason for the PR	entities are, by default, not refreshed in identity map after update with native query. This PR add a manual refresh of loaded entities, so it's safe to work with those entites after recalculations (=native queries).
New feature	No
BC breaks	No
Fixes issues	closes #2108
Have you read and signed our License Agreement for contributions?	Yes

[malyMiso]

Hi,

I was asked to check if this PR resolves scenario described in #2108. I have a question about performance. Couldn't it have an impact on performance while processing large amount of data, e.g. ProductVisibilityMidnightCronModule, or custom cron modules e.g importing data from IS.

However, I like this solution with provided test and it solves described problem. 👍

[grossmannmartin]

Hi,

I was asked to check if this PR resolves scenario described in #2108. I have a question about performance. Couldn't it have an impact on performance while processing large amount of data, e.g. ProductVisibilityMidnightCronModule, or custom cron modules e.g importing data from IS.

However, I like this solution with provided test and it solves described problem. 👍

Thank you for looking at this!
It's true that this can have a negative impact on the performance – most notably on the database (new queries are performed).

I'm afraid it's the price for updated data.

[malyMiso]

Hi,
I was asked to check if this PR resolves scenario described in #2108. I have a question about performance. Couldn't it have an impact on performance while processing large amount of data, e.g. ProductVisibilityMidnightCronModule, or custom cron modules e.g importing data from IS.
However, I like this solution with provided test and it solves described problem. +1

Thank you for looking at this!
It's true that this can have a negative impact on the performance – most notably on the database (new queries are performed).

I'm afraid it's the price for updated data.

I understand. I'm thinking about giving an option to disable refreshing entities on purpose. Adding parameter to refreshProductsVisibility could solve it (or new function ?). It would always refresh entities by default and PRG can change it explicitly

In cron modules, entities won't be refreshed
In a request, entities will be refreshed

Does it make sense ?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication