-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shopsys] fixed translations #1738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasLudvik
commented
Mar 23, 2020
Q | A |
---|---|
Description, reason for the PR | There were some old translation ids and uses in documentation - this was removed by this PR. |
New feature | No |
BC breaks | Yes |
Fixes issues | ... |
Have you read and signed our License Agreement for contributions? | Yes |
packages/framework/src/Form/Admin/Administrator/AdministratorFormType.php
Outdated
Show resolved
Hide resolved
grossmannmartin
requested changes
Mar 23, 2020
packages/framework/src/Model/PersonalData/Mail/PersonalDataAccessMail.php
Show resolved
Hide resolved
TomasLudvik
force-pushed
the
tl-remove-fixed-translations
branch
from
March 24, 2020 12:00
903d9ee
to
f8a8623
Compare
grossmannmartin
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and beautiful 👍
sslt
approved these changes
Mar 25, 2020
- removed all translations of english messages required only for this removement - updated documentation
TomasLudvik
force-pushed
the
tl-remove-fixed-translations
branch
from
March 25, 2020 09:52
5eb1ac7
to
7792a52
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.