[project-base] upgrade npm dependencies #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pesektomas
commented
Feb 7, 2020
•
pesektomas
commented
| Q | A |
|---|---|
| Description, reason for the PR | After run npm audit we have 53 vulnerabilities. If we updated some dev dependencies we can have 0 vulnerabilities. This PR updated dev dependencies. |
| New feature | No |
| BC breaks | No |
| Fixes issues | closes #756 |
| Have you read and signed our License Agreement for contributions? | Yes |
pesektomas
force-pushed
the
tp-upgrade-npm-dependencies
branch
3 times, most recently
from
60f5d24 to
2553d50
Compare
|
After regeneration of svg font - there is another style of closing cross (there is outline)- I think, we should change old svg icon for new one and it will be fixed - |
|
I just pushed new icon which looks much better. |
sslt
approved these changes
Feb 18, 2020
grossmannmartin
force-pushed
the
tp-upgrade-npm-dependencies
branch
from
bd67aa8 to
4d8064e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.