Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend-api] Entity images can now be loaded via fronted API #1486

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

TomasLudvik
Copy link
Member

Q A
Description, reason for the PR Images are necessary part of e-commerce solutions. This PR enabled possibility to load images of all current entities with images.
New feature Yes
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@TomasLudvik TomasLudvik changed the base branch from master to 9.0 October 31, 2019 13:30
@henzigo
Copy link
Member

henzigo commented Oct 31, 2019

Hello, can I call only one request for more images for same entityType?

For example, I have 24 products on product list, but I do not want to call 24 requests to get images for that.

@TomasLudvik
Copy link
Member Author

Hello, can I call only one request for more images for same entityType?

For example, I have 24 products on product list, but I do not want to call 24 requests to get images for that.

You do not have to, you can call it in query for all products.

@TomasLudvik TomasLudvik force-pushed the tl-api-images branch 3 times, most recently from b7d5cc3 to 0f24c71 Compare November 1, 2019 08:15
Copy link
Contributor

@s3tezsky s3tezsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it but still left a few comments.

And I would like to suggest add unit tests at least for ImageResolver. Also I am still thinking if ImageResolver should not be abstract class 🤔

Copy link
Contributor

@s3tezsky s3tezsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I send the query bellow, API will respond with HTML of 500 error page probably caused by cached files... everything as expected

{
  product(uuid: "foo") {
    images {
      url,
      type,
      size,
      width,
      height,
      position
    }
  }
}

@TomasLudvik TomasLudvik merged commit 8d6adbd into 9.0 Nov 5, 2019
@TomasLudvik TomasLudvik deleted the tl-api-images branch November 5, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants