project-base/app folder is now included in coding standards checks (#…

…1306) - fixed all the violations - router.php is skipped for ValidVariableNameSniff and ForbiddenSuperGlobalSniff as it needs to use superglobals
shopsys · Sep 9, 2019 · 3126182 · 3126182
1 parent fe47c32
commit 3126182
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 1 deletion.
diff --git a/app/AppCache.php b/app/AppCache.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Symfony\Bundle\FrameworkBundle\HttpCache\HttpCache;
 
 class AppCache extends HttpCache

diff --git a/app/AppKernel.php b/app/AppKernel.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\HttpKernel\Kernel;

diff --git a/app/Bootstrap.php b/app/Bootstrap.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Shopsys;
 
 use AppKernel;
@@ -79,7 +81,7 @@ public function run()
     private function configurePhp()
     {
         error_reporting(E_ALL);
-        ini_set('display_errors', 0);
+        ini_set('display_errors', '0');
     }
 
     private function initDoctrine()

diff --git a/app/Environment.php b/app/Environment.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Shopsys;
 
 use Composer\IO\IOInterface;

diff --git a/app/autoload.php b/app/autoload.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Doctrine\Common\Annotations\AnnotationRegistry;
 
 $loader = file_exists(__DIR__ . '/../vendor/autoload.php') ? require __DIR__ . '/../vendor/autoload.php' : require __DIR__ . '/../../vendor/autoload.php';

diff --git a/app/maintenance.php b/app/maintenance.php
@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
     header('HTTP/1.1 503 Service Temporarily Unavailable');
     header('Status: 503 Service Temporarily Unavailable');
     header('Retry-after: 300');

diff --git a/app/router.php b/app/router.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * This file implements rewrite rules for PHP built-in web server.
  *

diff --git a/easy-coding-standard.yml b/easy-coding-standard.yml
@@ -34,6 +34,7 @@ parameters:
         Shopsys\CodingStandards\Sniffs\ValidVariableNameSniff:
             - '*/tests/ShopBundle/Functional/EntityExtension/EntityExtensionTest.php'
             - '*/tests/ShopBundle/Test/Codeception/_generated/AcceptanceTesterActions.php'
+            - '*/app/router.php'
 
         Shopsys\CodingStandards\Sniffs\ObjectIsCreatedByFactorySniff:
             - '*/tests/*'
@@ -44,3 +45,6 @@ parameters:
         Shopsys\CodingStandards\Sniffs\ForbiddenDoctrineInheritanceSniff:
             - '*/src/Shopsys/ShopBundle/*'
             - '*/tests/ShopBundle/*'
+
+        Shopsys\CodingStandards\Sniffs\ForbiddenSuperGlobalSniff:
+            - '*/app/router.php'