This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
added chatbot #80
Merged
added chatbot #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasLudvik
commented
Sep 4, 2019
•
TomasLudvik
commented
| Q | A |
|---|---|
| Description, reason for the PR | Easier way to contact Shopsys directly from demoshop |
| New feature | Yes |
| Fixes issues | closes #79 |
| Have you read and signed our License Agreement for contributions? | Yes |
TomasLudvik
force-pushed
the
tl-add-chatbot
branch
2 times, most recently
from
065a580 to
42aff26
Compare
vitek-rostislav
suggested changes
Sep 5, 2019
There was a problem hiding this comment.
Hi @TomasLudvik, the chatbot should be displayed also in the administration so you will probably need to overwrite the base admin template as you did in #81
TomasLudvik
force-pushed
the
tl-add-chatbot
branch
2 times, most recently
from
dc8612c to
f07fcfe
Compare
Fixed |
vitek-rostislav
approved these changes
Sep 5, 2019
TomasLudvik
force-pushed
the
tl-add-chatbot
branch
from
f07fcfe to
f721fa8
Compare
LukasHeinz
approved these changes
Sep 6, 2019
TomasLudvik
force-pushed
the
tl-add-chatbot
branch
from
f721fa8 to
750f506
Compare
|
What should we do about the failing SonarCloud checks introduced in #72? After a short review the recommendations do seem relevant and useful. @grossmannmartin: Is the failing check a merge-stopper? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.