This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
upgrade to stable #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boris-brtan
commented
Mar 1, 2019
•
boris-brtan
commented
| Q | A |
|---|---|
| Description, reason for the PR | to improve UPGRADE instructions and try the stable release with project that contains external changes |
| New feature | Yes |
| BC breaks | Yes |
| Fixes issues | many |
| Standards and tests pass | Yes |
| Have you read and signed our License Agreement for contributions? | Yes |
boris-brtan
force-pushed
the
bb-upgrade-stable
branch
from
4c82f57 to
67c7b9b
Compare
DavidOstrozlik
suggested changes
Mar 4, 2019
tests/ShopBundle/Functional/Model/Cart/CartFacadeDeleteOldCartsTest.php
Outdated
Show resolved
Hide resolved
tests/ShopBundle/Functional/Model/Pricing/InputPriceRecalculationSchedulerTest.php
Outdated
Show resolved
Hide resolved
tests/ShopBundle/Functional/Model/Pricing/InputPriceRecalculationSchedulerTest.php
Outdated
Show resolved
Hide resolved
boris-brtan
force-pushed
the
bb-upgrade-stable
branch
from
01cba77 to
1c20da4
Compare
boris-brtan
force-pushed
the
bb-upgrade-stable
branch
from
1c20da4 to
169a350
Compare
vitek-rostislav
approved these changes
Mar 5, 2019
|
Beware that the |
DavidOstrozlik
approved these changes
Mar 6, 2019
boris-brtan
force-pushed
the
bb-upgrade-stable
branch
from
79253c9 to
0d4c7bd
Compare
added 7 commits
March 15, 2019 11:43
- dependencies in composer.json were upgraded to stable version - composer.lock were updated
- dump-translations target was executed - missing translations were introduced - CustomerController tranlatable exception was fixed
- datafixtures were copied into ShopBundle\Datafixture namespace - datafixture services were registrered in Resources/config/services/commands.yml and Resources/config/services/data_fixtures.yml - custom MailTemplates were merged - base directory for data fixture files were changed in paths.yml
- datafixtures, tests, discount change, templates and so, were fixed - new doctrine type were introduced into doctrine.yml - constraint and translations are fixed
boris-brtan
force-pushed
the
bb-upgrade-stable
branch
from
0d4c7bd to
783219c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.