Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GobEncode: avoid reallocating initial slice #355

Merged
merged 2 commits into from
Apr 3, 2024
Merged

GobEncode: avoid reallocating initial slice #355

merged 2 commits into from
Apr 3, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Mar 16, 2024

No description provided.

mwoss
mwoss approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@mwoss mwoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @serprex :D

decimal.go Show resolved Hide resolved
decimal.go Outdated Show resolved Hide resolved
@mwoss
Copy link
Member

mwoss commented Apr 3, 2024

LGTM! Ready for merge :3

@mwoss mwoss merged commit 547861c into shopspring:master Apr 3, 2024
epelc pushed a commit to greatcloak/decimal that referenced this pull request Apr 7, 2024
@serprex @epelc
Avoid reallocation of initial slice in MarshalBinary (GobEncode) (sho…
c54aa61 
…pspring#355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwoss mwoss mwoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @mwoss