Add NewFromBigRat function #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well,I also encountered this problem today. Do you have any other way to solve it? @davseby |
Hi, since this package seems to be no longer maintained, we've decided to fork it: It is not fully backwards compatible (differences are mentioned in the README). |
mwoss
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a convenience helper function that converts a
big.Ratto aDecimal. Since it is impossible to guarantee an exact accuracy, a precision attribute is used.Just as the
Divmethod has aDivRoundedmethod counterpart, perhaps this convenience function should have one as well? It could use theDivisionPrecisionvariable and wouldn't accept a precision parameter.