Remove unnecessary decimal rescaling - memory usage optimization #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to fix the performance issue mentioned in #81. Partially succeed as I couldn't simply return an already existing decimal object in
rescale
method due to some problems withDivMod
pointer receiver method that change decimal'svalue
attribute. As a workaround, I've createdRescalePair
helper function that rescales only one or none decimals from pair to avoid unnecessary memory allocations.Results of optimization shown below.
I've used benchmarks implemented by @ngalaiko in PR #102. Thanks for the contributions to the library, I really appreciate it.
Before:
After: