[14.0] shopinvader_image: improve image metadata handling #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods to get alt name and tag.
* do not ignore image.alt_name * count alt_name for store hash
simahawk
changed the title
mmequignon
approved these changes
Jul 31, 2024
mmequignon
approved these changes
Nov 12, 2024
Comment on lines
+84
to
+86
| self.shopinvader_variant.invalidate_cache(["images"]) | ||
| # value tags | ||
| self.shopinvader_variant.invalidate_cache(["images"]) |
There was a problem hiding this comment.
Suggested change
| self.shopinvader_variant.invalidate_cache(["images"]) | |
| # value tags | |
| self.shopinvader_variant.invalidate_cache(["images"]) | |
| # value tags | |
| self.shopinvader_variant.invalidate_cache(["images"]) |
When the tag is not valued is pointless to store empty values for all scales.
mmequignon
force-pushed
the
14-image-imp
branch
from
65abac6 to
bfc950c
Compare
|
tests are red, I'll have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see atomic commits for details.