-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shopinvader_algolia: Merge index configuration #1545
base: 14.0
Are you sure you want to change the base?
shopinvader_algolia: Merge index configuration #1545
Conversation
4f1f27d
to
b853ff7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing my 💩 😄
Then I guess my tests were poor... Could we improve them to make sure we have no override?
b853ff7
to
3e989fc
Compare
@simahawk can it be merged ? |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
3e989fc
to
9787089
Compare
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1545-by-simahawk-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Instead of being merged, index config was being overwritten