Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopinvader_algolia: Merge index configuration #1545

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

mmequignon
Copy link
Contributor

Instead of being merged, index config was being overwritten

@mmequignon mmequignon force-pushed the 14.0-shop_algolia-merge_index_config branch from 4f1f27d to b853ff7 Compare May 31, 2024 08:29
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my 💩 😄
Then I guess my tests were poor... Could we improve them to make sure we have no override?

@sebastienbeau sebastienbeau added this to the 14.0 milestone Jun 3, 2024
@mmequignon mmequignon force-pushed the 14.0-shop_algolia-merge_index_config branch from b853ff7 to 3e989fc Compare November 12, 2024 05:55
@mmequignon
Copy link
Contributor Author

@simahawk can it be merged ?

@simahawk
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1545-by-simahawk-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Nov 12, 2024
Signed-off-by simahawk
@mmequignon mmequignon force-pushed the 14.0-shop_algolia-merge_index_config branch from 3e989fc to 9787089 Compare November 14, 2024 10:56
@shopinvader-git-bot
Copy link

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1545-by-simahawk-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants